build-result: Make Failure an alias for BuildError#15070
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 29, 2026
Merged
build-result: Make Failure an alias for BuildError#15070Ericson2314 merged 1 commit intoNixOS:masterfrom
Failure an alias for BuildError#15070Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
amaanq
force-pushed
the
build-result-error-cleanup
branch
from
a739985 to
1d7c4e9
Compare
amaanq
changed the title
amaanq
changed the title
Failure an alias for BuildError
roberth
reviewed
Jan 23, 2026
Member
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup, also the decoupling from the worker protocol.
Comment on lines
+153
to
+157
| for (auto && [wire, val] : enumerate(buildResultStatusTable)) | ||
| if (val == status) { | ||
| conn.to << uint8_t(wire); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
This looks wasteful but is probably ok.
Something more direct would be nice, but I assume this isn't in the hot path, so let's not sweat it.
Member
There was a problem hiding this comment.
This is the first commit btw. I assume the compiler will be excited to optimize this, hehe. :)
amaanq
force-pushed
the
build-result-error-cleanup
branch
3 times, most recently
from
3520180 to
19d03c9
Compare
amaanq
force-pushed
the
build-result-error-cleanup
branch
from
19d03c9 to
c94ab82
Compare
github-actions
bot
added
the
with-tests
amaanq
force-pushed
the
build-result-error-cleanup
branch
from
c94ab82 to
9f5a6d7
Compare
|
🎉 All dependencies have been resolved ! |
amaanq
force-pushed
the
build-result-error-cleanup
branch
from
9f5a6d7 to
ebe702d
Compare
Ericson2314
approved these changes
Jan 27, 2026
|
|
||
| Goal::Done PathSubstitutionGoal::doneFailure(ExitCode result, BuildResult::Failure::Status status, std::string errorMsg) | ||
| { | ||
| debug(errorMsg); |
Member
There was a problem hiding this comment.
I think the new codepath doesn't issue this debug, do we care?
Member
Author
There was a problem hiding this comment.
We got rid of this function because it was a redundant wrapper around Goal::doneFailure, I believe the debug log isn't something we care about but John can gut check me on that.
lovesegfault
approved these changes
Jan 28, 2026
…eption parameters from goal
amaanq
force-pushed
the
build-result-error-cleanup
branch
from
ebe702d to
de88141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR makes
BuildResult::Failurea type alias forBuildError, so failures can be thrown directly without maintaining a separate exception field.Context
Previously, the goal system tracked failures in two places:
BuildResult::Failurestruct inbuildResult.innerstd::optional<Error> exfield onGoalI've set an alias
BuildResult::Failure = BuildError(note thatBuildErrorinherits fromError). This lets us remove the exception parameters fromdoneFailure(), and also lets us remove theGoal::exfield. Now, we usebuildResult.tryGetFailure()to get a throwable exception directly.The
ecNoSubstitutersexit code is handled specially in that it sets aFailureinbuildResultbut isn't logged as an error, since it effectively means "we couldn't substitute, will try building instead."Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.