libstore: split out GCSettings#15058
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jan 23, 2026
Merged
Conversation
github-actions
bot
added
new-cli
amaanq
force-pushed
the
split-gc-settings
branch
4 times, most recently
from
f94137f to
34002d6
Compare
Ericson2314
reviewed
Jan 22, 2026
amaanq
force-pushed
the
split-gc-settings
branch
3 times, most recently
from
9806f4d to
865ff4a
Compare
This PR follows the same approach as NixOS#15043 and the [`LogFileSettings`](NixOS#15051) extraction: - `GCSettings` struct inherits from virtual `Config` - `Settings` privately inherits from it - Accessed through `getGCSettings()` The new method on `LocalStoreConfig` anticipates on making these settings per-store. 0b606aa added both the autoGC and periodic wakeups, which is why we think they are related.
amaanq
force-pushed
the
split-gc-settings
branch
from
865ff4a to
6f0fe56
Compare
Ericson2314
approved these changes
Jan 22, 2026
edolstra
approved these changes
Jan 23, 2026
edolstra
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The GC settings (
reservedSize,keepOutputs,keepDerivations,minFree,maxFree,minFreeCheckInterval) are all related to garbage collection but currently live scattered across the largeSettingsclass.Context
This PR follows the same approach as #15043 and the
LogFileSettingsextraction:GCSettingsstruct inherits fromvirtual ConfigSettingsprivately inherits from itgetGCSettings()The new method on
LocalStoreConfiganticipates on making thesesettings per-store. 0b606aa added both
the autoGC and periodic wakeups, which is why we think they are related.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.