libstore: add SQLite::Settings struct for explicit configuration#15050
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 22, 2026
Merged
libstore: add SQLite::Settings struct for explicit configuration#15050Ericson2314 merged 1 commit intoNixOS:masterfrom
SQLite::Settings struct for explicit configuration#15050Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
store
Ericson2314
approved these changes
Jan 22, 2026
amaanq
force-pushed
the
sqlite-settings-struct
branch
from
a898d96 to
4240342
Compare
Member
|
Approving this because while my coworker wrote this based on my own refactor, we specifically authorized this change in the meeting yesterday. |
Progress on NixOS#5638 Replace the SQLite constructor's mode parameter with a Settings struct that includes both the open mode and useWAL flag. This makes the dependency on useSQLiteWAL explicit at call sites rather than having it read from the global settings inside the constructor. All call sites now explicitly pass settings.useSQLiteWAL, preparing for downstream work where stores can pass their own settings instead of relying on the global.
auto-merge was automatically disabled
January 22, 2026 17:06
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
sqlite-settings-struct
branch
from
4240342 to
751a0f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR progresses #5638
The
SQLiteconstructor currently readssettings.useSQLiteWALdirectly from the global settings object. We can improve this by adding aSQLite::Settingsstruct that callers must provide, and this makes the data flow explicit. All call sites now explicitly passsettings.useSQLiteWAL.Context
This is extracted from the larger WIP commit that eliminates global
Settingsin libstore. The SQLite changes are self-contained.The struct bundles
mode(the existing open mode parameter) withuseWAL, keeping related configuration together rather than adding a second parameter.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.