libstore: make withAWS depend on aws-c-common availability#15021
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 20, 2026
Merged
libstore: make withAWS depend on aws-c-common availability#15021Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Ericson2314
reviewed
Jan 20, 2026
src/libstore/package.nix
Outdated
Comment on lines
+28
to
+30
| stdenv.hostPlatform == stdenv.buildPlatform | ||
| && (stdenv.isLinux || stdenv.isDarwin) | ||
| && lib.meta.availableOn stdenv.hostPlatform aws-c-common, |
Member
There was a problem hiding this comment.
Suggested change
| stdenv.hostPlatform == stdenv.buildPlatform | |
| && (stdenv.isLinux || stdenv.isDarwin) | |
| && lib.meta.availableOn stdenv.hostPlatform aws-c-common, | |
| lib.meta.availableOn stdenv.hostPlatform aws-c-common, |
what if we just did that? I think the other stuff was just a crude proxy for this anyways --- we can say what we really mean instead!
Contributor
Author
There was a problem hiding this comment.
If you say that that's what it was supposed to mean, then sure.
Member
There was a problem hiding this comment.
Great thanks, and would you mind replicating this back in Nixpkgs, too?
OPNA2608
force-pushed
the
fix/libstore-ppc64
branch
from
5e06759 to
37834c5
Compare
Ericson2314
approved these changes
Jan 20, 2026
Contributor
|
Has this borked nixStatic? https://hydra.nixos.org/build/319583921/nixlog/1 |
Member
|
Ah better skip for now, good call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Nixpkgs: NixOS/nixpkgs#481712
Motivation
Context
NixOS/nixpkgs#481712
NixOS/nixpkgs#425407
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.