libutil: fix linux build on fresh glibc and gcc#15011
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Jan 17, 2026
Merged
Conversation
xokdvium
added
the
backport 2.33-maintenance
Contributor
Hm, I guess the |
Without the change the build fails for me as:
../unix/file-descriptor.cc:404:70: error: 'RESOLVE_BENEATH' was not declared in this scope
404 | dirFd, path.rel_c_str(), flags, static_cast<uint64_t>(mode), RESOLVE_BENEATH | RESOLVE_NO_SYMLINKS);
| ^~~~~~~~~~~~~~~
This happens for 2 reasons:
1. `__NR_openat2` constant was not pulled in from the according headers
and as a result `<linux/openat2.h>` was not included.
2. `define HAVE_OPENAT2 0` build is broken: refers to missing
`RESOLVE_BENEATH` normally pulled in from `<linux/openat2.h>`
This changes fixes both.
trofi
force-pushed
the
lixnu-openat-sysno
branch
from
c78f70c to
3256aba
Compare
Contributor
Author
Sound good! Amended with the change to |
Contributor
|
Also, how fresh of a glibc are we talking about? |
xokdvium
approved these changes
Jan 17, 2026
|
Successfully created backport PR for |
Contributor
Author
|
Contributor
|
Oh, so we need to grab the patch on |
Contributor
|
Grabbed the backport in NixOS/nixpkgs#481478 |
github-merge-queue bot
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jan 19, 2026
Fixes a missing include on newer glibc 2.42 that is currently in staging-next. See NixOS/nix#15011.
philiptaron
added a commit
to philiptaron/nixpkgs
that referenced
this pull request
Feb 7, 2026
## Bug fixes - Fix destruction of DerivationBuilder implementations (NixOS/nix#15072) - Don't report cancelled goals as failures (NixOS/nix#14972) - Fix `linux` build on fresh `glibc` and `gcc` (NixOS/nix#15011) ## S3 binary cache improvements - Add AWS SSO support for S3 authentication (NixOS/nix#14645) - Respect `AWS_PROFILE` environment variable (NixOS/nix#14645) - Add STS support for default profile (NixOS/nix#14645) - Skip `Accept-Encoding` header for S3 SigV4 requests (NixOS/nix#15048) - Restart source before upload retries (NixOS/nix#15047) - Route AWS CRT logs through Nix logger (NixOS/nix#15059) The glibc 2.42 build fix patch is dropped as it is now included upstream. https://github.com/NixOS/nix/releases/tag/2.33.2
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the build fails for me as:
This happens for 2 reasons:
__NR_openat2constant was not pulled in from the according headers and as a result<linux/openat2.h>was not included.define HAVE_OPENAT2 0build is broken: refers to missingRESOLVE_BENEATHnormally pulled in from<linux/openat2.h>This changes fixes both.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.