tests: use valid signature format in protocol characterization tests#15010
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 17, 2026
Merged
tests: use valid signature format in protocol characterization tests#15010Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Ericson2314
reviewed
Jan 16, 2026
Ericson2314
reviewed
Jan 16, 2026
Ericson2314
reviewed
Jan 16, 2026
amaanq
force-pushed
the
fix-test-signature-format
branch
2 times, most recently
from
6dc0e67 to
b4225bb
Compare
Ericson2314
reviewed
Jan 16, 2026
amaanq
force-pushed
the
fix-test-signature-format
branch
2 times, most recently
from
28246fb to
0979ca1
Compare
The test data was using invalid signature strings like "asdf" and "qwer" which don't follow the required "name:base64signature" format. This updates them to use properly formatted signatures with valid base64-encoded data.
amaanq
force-pushed
the
fix-test-signature-format
branch
from
0979ca1 to
51ca872
Compare
Member
|
@amaanq works with me, so I would not normally merge his work, but this is just updating tests. I have hand-reviewed the binary format diffs to make sure there are not other accidental changes. In particular, the tests with the now-deprecated dependent realizations still have that field non-empty. |
Ericson2314
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The protocol characterization tests use placeholder signature strings like "asdf" and "qwer" which don't follow the valid signature format (name:base64signature). This makes the test data inconsistent with real-world usage and will cause failures when stricter signature validation is introduced (#15009)
Context
This change was extracted from a larger PR (#15009) which introduces a
Signaturetype with validation. Separating it out keeps the main PR's diff cleaner and easier to review.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.