Skip to content

fetchTree: reject relative file: paths for tarballs #14983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edolstra merged 2 commits into from
Jan 13, 2026
Merged

fetchTree: reject relative file: paths for tarballs #14983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a7178
fetchTree: reject relative file: paths for tarballs
roberth Jan 12, 2026
b19bfc6
fetchTree: improve relative path error wording
roberth Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libfetchers/tarball.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,12 @@ static DownloadTarballResult downloadTarball_(
// it is not in fact a tarball.
if (url.scheme == "file") {
std::filesystem::path localPath = renderUrlPathEnsureLegal(url.path);
if (!localPath.is_absolute()) {
throw Error(
"tarball '%s' must use an absolute path. "
"The 'file' scheme does not support relative paths.",
url);
}
if (!exists(localPath)) {
throw Error("tarball '%s' does not exist.", localPath);
}
Expand Down
10 changes: 10 additions & 0 deletions tests/functional/lang/eval-fail-fetchTree-relative-path.err.exp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
error:
… while calling the 'fetchTree' builtin
at /pwd/lang/eval-fail-fetchTree-relative-path.nix:1:1:
1| builtins.fetchTree "file:./relative-path.tar.gz"
| ^
2|

… while fetching the input 'file:./relative-path.tar.gz'

error: tarball 'file:./relative-path.tar.gz' must use an absolute path. The 'file' scheme does not support relative paths.
1 change: 1 addition & 0 deletions tests/functional/lang/eval-fail-fetchTree-relative-path.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
builtins.fetchTree "file:./relative-path.tar.gz"
Loading