fixGitURL: fix crash for "relative" file: paths and reject unsupported SCP URLs#14981
Merged
edolstra merged 1 commit intoNixOS:masterfrom Jan 13, 2026
Merged
Conversation
Relative paths (e.g., "relative/repo") would crash in renderAuthorityAndPath() because an empty authority was set, violating RFC 3986 section 3.3 which requires paths to start with "/" when an authority is present. Fix by only setting authority for absolute paths: - Absolute paths: file:///path (empty authority) - Relative paths: file:path (no authority) Also reject SCP-like URLs without a user (e.g., "github.com:path") with a clear error message, since proper support requires careful implementation, which is not something I can do right now.
roberth
changed the title
fixGitURL: fix crash for relative paths and reject unsupported SCP URLsfixGitURL: fix crash for "relative" file: paths and reject unsupported SCP URLs
edolstra
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative paths (e.g.,
"relative/repo") would crash inrenderAuthorityAndPath()because an empty authority was set, violating RFC 3986 section 3.3 which requires paths to start with "/" when an authority is present.Fix by only setting authority for absolute paths:
file:///path(empty authority)file:path(no authority)Also reject SCP-like URLs without a user (e.g.,
"github.com:path") with a clear error message, since proper support requires careful implementation, which is not something I can do right now.Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.