Add missing shebangs to exorcise Darwin sandbox heisenbug#14969
Add missing shebangs to exorcise Darwin sandbox heisenbug#14969
Conversation
|
@agucova cc. I don't have apple hardware to test this one. Could you give that a shot, since you were able to repro these kind of issues reliably? |
Adds missing shebangs that lead to unsafe forks that present themselves as SIGSEGV. See 7b3d7eb and NixOS/nixpkgs#476794 Lix patch: https://gerrit.lix.systems/c/lix/+/4891
8328fad to
546127f
Compare
|
@xokdvium sadly I couldn't replicate the original test failures on my M4 Max Macbook Pro, so I can't confirm whether this fixes the heisenbug or not |
|
One observation is that hydra builds run on macOS 26. Maybe it has something to do with it? |
|
The issue happened in my setup like every run, M4 Pro/48 Gb/MacOS 26.2. There were three failing tests, each and any of them could pass any time, but never all three: I can confirm that this PR fixes the issue for me. |
|
I will try on a M4 MacBook Pro with Tahoe 26.2 on it and try to run with sandboxed to relaxed, on and off tomorrow. |
Note I already tested on Tahoe 26.2 |
That's what we observe on hydra too. In the meantime I've opened a PR disabling those tests in nixpkgs NixOS/nixpkgs#481478. Since the rcfile change would be a breaking change this seems like the best way forward for the old versions. |
|
Huh weird It passed when I did a Log:Nix-info: |
|
I have ruled out all possibilities on my system. I have a feeling it's a bit flaky not an actual system issue. |
|
What do you mean? This PR is supposed to fix the issues, so it's expected that building on this PR would pass. |
Oh wait I forgot to test upstream... I will do that and compare. |
|
Still upstream passes... I feel like there needs to be talk about the flakiness. On some machines it will just work, then some won't work. |
Motivation
Adds missing shebangs that lead to unsafe forks that present themselves as SIGSEGV.
See 7b3d7eb and NixOS/nixpkgs#476794 Lix patch: https://gerrit.lix.systems/c/lix/+/4891
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.