Fix mingw build (once again), add openFileReadonly and clean up error.hh to include WinError#14962
Conversation
This way each consumer of NativeSysError doesn't have to also conditionally include the windows-error.hh, which is very cumbersome. And we can't include windows-error.hh in error.hh because of a circular import.
This also adds a utility for opening a file descriptor from a path in readonly mode. Previous commit helps a bit with error handling, since now we just throw a NativeSysError.
Ericson2314
reviewed
Jan 10, 2026
| assert(cacheDir); | ||
| return (*cacheDir / hashPart) + "." + ext; | ||
| auto res = (*cacheDir / hashPart); | ||
| res.concat(concatStrings(".", ext)); |
Member
There was a problem hiding this comment.
Any reason not two += instead?
Contributor
Author
There was a problem hiding this comment.
That's pretty equivalent. More of a matter of taste
Ericson2314
reviewed
Jan 10, 2026
| * | ||
| * @note For directories use @ref openDirectory. | ||
| */ | ||
| Descriptor openFileReadonly(const std::filesystem::path & path); |
Member
There was a problem hiding this comment.
git grep O_RDONLY makes me think this could perhaps be used in more places.
Ericson2314
approved these changes
Jan 10, 2026
JustAGuyTryingHisBest
pushed a commit
to JustAGuyTryingHisBest/nix
that referenced
this pull request
Jan 12, 2026
Fix mingw build (once again), add openFileReadonly and clean up error.hh to include WinError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://hydra.nixos.org/build/318597613
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.