fix: replace unused-result of set::extract with erase#14911
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Jan 5, 2026
Merged
fix: replace unused-result of set::extract with erase#14911xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
As of llvm/llvm-project#169982 this will be caught by LLVM, and it's the only such example.
tomfitzhenry
changed the title
xokdvium
approved these changes
Jan 2, 2026
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
Hm, not sure it's a correctness issue. node_handle does free the element in its destructor, but erase is more concise. libc++ might be too aggressive with [[nodiscard]] here.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of llvm/llvm-project#169982 this occurence is caught by LLVM, and it's the only such example.
I don't think believe this changes behaviour.
For context, #5106 introduced the
extractcall.Motivation
Nix builds with
Werror=unused-resultand as of llvm/llvm-project#169982 that this will catch more cases.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.