Conversation
xokdvium
requested review from
Ericson2314,
fzakaria and
roberth
and removed request for
Ericson2314,
edolstra and
roberth
|
@fzakaria, agree this is unfortunate. I tried making this work better with the dev shell setups and hydra jobsets that we have and that's sadly a total pain in the butt with the amount of platforms we need to target. That's quite a bit of maintenance burden for something that making evaluate on hydra would take a non-trivial amount of hackery. Sorry :( |
|
This is the most pragmatic approach that I've found. Wish there was a better way to have non-critical components, but we have quite a bit of maintenance burden on our side for existing things like i686, static and cross that needs constant maintenance and it's not getting as much attention as it needs to already. Something Java-related is a bit too much. |
|
I wonder if keeping them as independent builds for the CI process would make sense? If not, then I suggest deleting the kaitai code, since it will inevitably grow stale and increasingly wrong. |
As said there is no benefits for keeping the checks and we can't gaunteee that it will work on other systems than linux. So it be removed we can always we add it back later if there is proven a needed benefit than a toy example we can revisit it later on. |
Pulling in the java into the tests closure for just testing a piece of code for the docs (and the tests actually are wrong, since a correct parser must *reject* those NARs). This is too much of an ask to maintain for zero benefit. I already had to disable it basically everywhere, because it works only on linux. It can be revisited in the future, but considering that it's not exercised anywhere and shouldn't be used anywhere other than a toy example for the docs I think it's best to drop it.
Ericson2314
force-pushed
the
drop-kaitai
branch
from
eeadff0 to
ab7c0ae
Compare
5 participants
Motivation
Pulling in the java into the tests closure for just testing a piece of code for the docs (and the tests actually are wrong, since a correct parser must reject those NARs). This is too much of an ask to maintain for zero benefit. I already had to disable it basically everywhere, because it works only on linux.
It can be revisited in the future, but considering that it's not exercised anywhere and shouldn't be used anywhere other than a toy example for the docs I think it's best to drop it.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.