ci: Move docker_push_image into a separate workflow #14872
Merged
xokdvium merged 3 commits intoNixOS:masterfrom Dec 28, 2025
Merged
ci: Move docker_push_image into a separate workflow #14872xokdvium merged 3 commits intoNixOS:masterfrom
xokdvium merged 3 commits intoNixOS:masterfrom
Conversation
Best reviewed with -w --color-moved. This just moves the code into a separate workflow. This will allow us to reuse it in the release job for github releng of releases.
This should allow reusing this workflow (with more tweaks) in the releng workflow.
Contributor
Author
|
Tested in my own fork/repos. Seems to do the right thing. (Looking at this setup, I'm quite skeptical of why we push master as latest to GHCR, hopefully we'll get this fixed once we automate release uploads and we can easily add GHCR to the release scope). |
Mic92
approved these changes
Dec 28, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.31-maintenance
git worktree add -d .worktree/backport-14872-to-2.31-maintenance origin/2.31-maintenance
cd .worktree/backport-14872-to-2.31-maintenance
git switch --create backport-14872-to-2.31-maintenance
git cherry-pick -x 745983dfc057c6b645cad93190be9fab0058208e fb05f6de0d508225d0724c3e87052b5606a623d2 c867ed6726ffd0cf739b14d08917b86fd3492ff2 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.32-maintenance
git worktree add -d .worktree/backport-14872-to-2.32-maintenance origin/2.32-maintenance
cd .worktree/backport-14872-to-2.32-maintenance
git switch --create backport-14872-to-2.32-maintenance
git cherry-pick -x 745983dfc057c6b645cad93190be9fab0058208e fb05f6de0d508225d0724c3e87052b5606a623d2 c867ed6726ffd0cf739b14d08917b86fd3492ff2 |
|
Git push to origin failed for 2.33-maintenance with exitcode 1 |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This should allow reusing this workflow (with more tweaks)
in the releng workflow. Best reviewed with -w --color-moved.
Currently this workflow is only run for master branch, but in the future
we'll adapt it for maintenance- branches too.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.