Skip to content

[Backport 2.33-maintenance] libstore: include path in the world-writable error #14850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
internal-nix-ci merged 1 commit into from
Dec 21, 2025
Merged

[Backport 2.33-maintenance] libstore: include path in the world-writable error #14850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/libstore/unix/build/derivation-builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,17 +678,17 @@ static void handleChildException(bool sendException)
}
}

static bool checkNotWorldWritable(std::filesystem::path path)
static void checkNotWorldWritable(std::filesystem::path path)
{
while (true) {
auto st = lstat(path);
if (st.st_mode & S_IWOTH)
return false;
throw Error("Path %s is world-writable or a symlink. That's not allowed for security.", path);
if (path == path.parent_path())
break;
path = path.parent_path();
}
return true;
return;
}

std::optional<Descriptor> DerivationBuilderImpl::startBuild()
Expand All @@ -710,9 +710,8 @@ std::optional<Descriptor> DerivationBuilderImpl::startBuild()

createDirs(buildDir);

if (buildUser && !checkNotWorldWritable(buildDir))
throw Error(
"Path %s or a parent directory is world-writable or a symlink. That's not allowed for security.", buildDir);
if (buildUser)
checkNotWorldWritable(buildDir);

/* Create a temporary directory where the build will take
place. */
Expand Down
Loading