Fix empty input path segfault (#14816)#14846
Merged
xokdvium merged 6 commits intoNixOS:masterfrom Dec 22, 2025
Merged
Conversation
An empty attribute path refers to the flake itself, contradicting the purpose of --override-input, which is for overriding inputs. Fixes: NixOS#14816
An empty attribute path refers to the flake itself, contradicting the purpose of input overrides, which are for overriding inputs. Related: NixOS#14816
Wraps InputAttrPath with compile-time guarantee of non-emptiness. Replaces obscure .back() calls with domain-specific inputName() method. An empty path refers to the flake itself, making it nonsensical for input override operations. The type system now prevents this.
An empty path refers to the flake itself, not an input. Apply the same type safety to inputUpdates as inputOverrides. The deprecated --update-input flag (deprecated since Nix 2.4) and the modern 'nix flake update' command now properly reject empty paths. Includes functional tests for both commands.
Make the error message more explicit about what went wrong and why it's invalid. The new message explains that a zero-length path was passed and clarifies that it would refer to the flake itself.
Make the C API error message more explicit about what went wrong and why it's invalid. The new message explains that a zero-length path was passed and clarifies that it would refer to the flake itself. Updates the unit test to match the new error message.
github-actions
bot
added
new-cli
xokdvium
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nix flake lock --override-input "" .SIGSEGVs #14816--updat-input ""NonEmptyInputAttrPathContext
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.