libstore: reduce allocations in StoreDirConfig::printStorePath#14825
Closed
Zaczero wants to merge 1 commit intoNixOS:masterfrom
Closed
libstore: reduce allocations in StoreDirConfig::printStorePath#14825Zaczero wants to merge 1 commit intoNixOS:masterfrom
Zaczero wants to merge 1 commit intoNixOS:masterfrom
Conversation
StoreDirConfig::printStorePath() previously built an intermediate string via storeDir + "/" and then appended the store-path basename, which can trigger an extra allocation/copy.
Contributor
|
Also sounds good, though I doubt this would have lead to extra allocations because of small string optimization (libstdc++ stores 16 bytes inline iirc, something similar for libc++). Still this should have one less copy constructor which is good. |
Ericson2314
requested changes
Dec 18, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Good idea, but I think we can shorten it while not loosing the benefits: see concatStrings. If you follow the templates, it does the same thing.
Member
Author
|
I merged this PR with #14823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StoreDirConfig::printStorePath() previously built an intermediate string via storeDir + "/" and then appended the store-path basename, which can trigger an extra allocation/copy.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.