doc: drop rsync dependency from manual build#14824
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Dec 18, 2025
Merged
Conversation
rsync was only used to copy source files while following symlinks. Replace with tar --dereference, which serves the same purpose. Tried plain cp but couldn't get it to work reliably. tar is already a test dependency. Add tests/functional/derivation to fileset to include the symlink targets. Fixes NixOS#14776
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
rsync was only used to copy source files while following symlinks. Replace with tar --dereference, which serves the same purpose. Tried plain cp but couldn't get it to work reliably. tar is already a test dependency.
Add tests/functional/derivation to fileset to include the symlink targets.
Output compares equal
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.