LocalBinaryCacheStore::upsertFile support slash in path#14821
Merged
tomberek merged 1 commit intoNixOS:masterfrom Dec 31, 2025
Merged
LocalBinaryCacheStore::upsertFile support slash in path#14821tomberek merged 1 commit intoNixOS:masterfrom
LocalBinaryCacheStore::upsertFile support slash in path#14821tomberek merged 1 commit intoNixOS:masterfrom
Conversation
While working on NixOS#12464, I realized this method was not correct in this case. With the current binary cache format, it is harmless, since we don't create arbitrary directories, but with my change, we started to. Regardless of whether we need it or not, I think it is better if the function just does the right thing.
github-actions
bot
added
the
store
Contributor
|
Wouldn't we be able to just create the directory up-front instead? Seems pretty wasteful when we can just do this once. |
Member
Author
|
We could, but I figured the cost is low, and it is easier to do it, than document "this must only create paths in directories that already existed. It is not nice to have special invariants that are only in one implementation but not others, of a virtual method, though the fact that is a protected (IIRC) does help a little bit. |
tomberek
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While working on #12464, I realized this method was not correct in this case. With the current binary cache format, it is harmless, since we don't create arbitrary directories, but with my change, we started to.
Motivation
Regardless of whether we need it or not, I think it is better if the function just does the right thing.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.