libutil: Add CompressionAlgo enum, add Suggestions to UnknownCompress…#14814
Merged
Ericson2314 merged 1 commit intomasterfrom Dec 17, 2025
Merged
libutil: Add CompressionAlgo enum, add Suggestions to UnknownCompress…#14814Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
Ericson2314
reviewed
Dec 16, 2025
| using FinishSink::finish; | ||
| }; | ||
|
|
||
| enum class CompressionAlgo { none, brotli, bzip2, compress, grzip, gzip, lrzip, lz4, lzip, lzma, lzop, xz, zstd }; |
Member
There was a problem hiding this comment.
Suggested change
| enum class CompressionAlgo { none, brotli, bzip2, compress, grzip, gzip, lrzip, lz4, lzip, lzma, lzop, xz, zstd }; | |
| enum class CompressionAlgo { none, brotli, bzip2, compress, grzip, gzip, lrzip, lz4, lzip, lzma, lzop, xz, zstd, }; |
I like trailing comma better, then it will do one on each line
…ionMethod exception
Error messages now include suggestions like:
error: unknown compression method 'bzip'
Did you mean one of bzip2, gzip, lzip, grzip or lrzip?
Also a bit of progress on making the compression code use less stringly
typed compression type, which is good because it's easy to confuse
which strings are accepted where (e.g. Content-Encoding should be able
to accept x-gzip, but it shouldn't be exposed in NAR decompression and
so on). An enum cleanly separates the concerns of parsing strings / handling
libarchive write/read filters.
xokdvium
force-pushed
the
suggestions-compression-algo-enum
branch
from
c61b066 to
4060ec3
Compare
Ericson2314
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ionMethod exception
Motivation
Error messages now include suggestions like:
Also a bit of progress on making the compression code use less stringly typed compression type, which is good because it's easy to confuse which strings are accepted where (e.g. Content-Encoding should be able to accept
x-gzip, but it shouldn't be exposed in NAR decompression and so on). An enum cleanly separates the concerns of parsing strings / handling libarchive write/read filters.Context
Would be helpful for fixing #14324.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.