Merged
Conversation
- More concise - Also checks error messages - Checks more error codes The nature of that bug is that if the first command's exit status is correctly 101 and not 1, the rest should be correctly 101, 100, etc. too.
github-actions
bot
added
the
with-tests
roberth
reviewed
Dec 18, 2025
| fi | ||
| # FIXME: https://github.com/NixOS/nix/issues/4813 | ||
| expectStderr 101 nix-build -Q timeout.nix -A infiniteLoop --timeout 2 | grepQuiet "timed out" \ | ||
| || skipTest "Do not block CI until fixed" |
Member
There was a problem hiding this comment.
skipTest cancels the whole test file, which is unexpected. Easy to miss when reading this test.
|| is for flaky tests, at best. What we should have here is a negation, so that when the behavior is fixed, the test must be updated to reflect the new state and actually test it.
Member
Author
There was a problem hiding this comment.
This is how it worked before too, fwiw. Not ideal, but not worse in this case either.
The real condition is that the return code should either by 1xy (good) or 1 (bug). But of course the best thing is just fixing the bug.
roberth
approved these changes
Dec 18, 2025
xokdvium
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
The nature of that bug is that if the first command's exit status is correctly 101 and not 1, the rest should be correctly 101, 100, etc. too.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.