Merged
Conversation
No copying allowed Co-authored-by: Sergei Zimmerman <sergei@zimmerman.foo>
These can't be copied and moving requires special logic too.
Good to explicitly declare things to not accidentally do twice the work by preventing that kind of misuse. This is essentially just cppcoreguidelines-special-member-functions lint in clang-tidy.
xokdvium
force-pushed
the
fix-special-member-functions-a-lot
branch
from
f38aebe to
1986287
Compare
Ericson2314
approved these changes
Dec 15, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Approve, but why not do the default move constructors when it works? That part I don't understand.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
treewide: Follow rule of five
tomberek
approved these changes
Dec 15, 2025
Contributor
tomberek
left a comment
tomberek
left a comment
There was a problem hiding this comment.
Not having these be explicit has often confused me. It's a style thing that ends up having contribution impacts.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Good to explicitly declare things to not accidentally do twice the work by
preventing that kind of misuse.
This is essentially just cppcoreguidelines-special-member-functions lint
in clang-tidy.
Context
Pulled out PathLocks changes from #14788, but with explicit implementations instead of explicitly defaulting.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.