Closed
Conversation
It should not effect move / copy / etc. constructors.
github-actions
bot
added
documentation
new-cli
Ericson2314
force-pushed
the
hash-conv-json
branch
from
50097b2 to
a243a65
Compare
Now that `nix path-info --json --json-format 2` and `nix derivation show` use the new structural JSON format for hashes, it is good for `nix hash convert` to also support this format. Dogfood this in a NixOS test that needs that.
Ericson2314
force-pushed
the
hash-conv-json
branch
from
a243a65 to
e02f722
Compare
Mic92
approved these changes
Dec 8, 2025
Member
Mic92
left a comment
Mic92
left a comment
There was a problem hiding this comment.
Code seems fine, don't have a strong opinion on the feature itself.
Member
Author
|
Closing in favor of this #14743 . If we don't have this structural JSON format and just use SRI, we don't need to extend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now that
nix path-info --json --json-format 2andnix derivation showuse the new structural JSON format for hashes, it is good fornix hash convertto also support this format.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.