turn 'derivation has incorrect deferred output' into warning#14739
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Dec 8, 2025
Merged
turn 'derivation has incorrect deferred output' into warning#14739Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
Member
Author
|
@xokdvium this is the alternative. Another alternative would be dropping the check altogether. |
Contributor
|
This seems much saner than breaking daemon compat (even if it's for an XP feature only). |
Member
|
@xokdvium I don't really want to do this, because
At most, I would want this to be a transitional thing just for 2.33. |
Ericson2314
reviewed
Dec 8, 2025
Ericson2314
reviewed
Dec 8, 2025
Ericson2314
reviewed
Dec 8, 2025
Mic92
force-pushed
the
nix-develop
branch
2 times, most recently
from
c4c3f17 to
cd11daf
Compare
Ericson2314
reviewed
Dec 8, 2025
Ericson2314
reviewed
Dec 8, 2025
this breaks nix develop when using a stable nix version Update src/libstore/derivations.cc Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
force-pushed
the
nix-develop
branch
from
bffc9ff to
623f3d3
Compare
Ericson2314
approved these changes
Dec 8, 2025
Ericson2314
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this breaks nix develop when using a stable nix version with ca derivations enabled on obht.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.