builtins.path: Propagate references from derivation outputs#14736
Merged
builtins.path: Propagate references from derivation outputs#14736
Conversation
This restores compatibility with Nix 2.18, which behaved this way. Note that this doesn't scan for the actually visible references. Unlike in Nix 2.18, we only do this for paths with context, i.e. it applies to `builtins.storePath "/nix/store/bla..."` but not `"/nix/store/bla..."`. We don't want the latter because it shouldn't matter whether a source file happens to be in the Nix store.
github-actions
bot
added
the
with-tests
Mic92
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This restores compatibility with Nix 2.18, which behaved this way. (This behaviour was first lost in ea38605.) Note that this doesn't scan for the actually visible references.
Unlike in Nix 2.18, we only do this for paths with context, i.e. it applies to
builtins.storePath "/nix/store/bla..."but not"/nix/store/bla...". We don't want the latter because it shouldn't matter whether a source file happens to be in the Nix store.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.