Merged
Conversation
…nux with sanitizers This somehow fails https://hydra.nixos.org/build/315675349/nixlog/1. I don't know the exact details, but it seems that something goes very wrong with LTO and sanitizers that lead to the string literal to be moved? Instead of relying on the string literal deduplication to provide a consistent address we can use a global. That should have a single address (modulo wonky copy relocations).
It's not evaling on hydra currently and is only part of the docs. Support for this it best effort at best so we should not build this in hydra, considering the amount of effort required to support this. I would even consider dropping these checks and component altogether, since there doesn't seem to be much interest in maintaining these docs from the core team anyway.
Member
|
I'm surprised katai structs is broken because it worked just fine in the full dev shell. |
Contributor
Author
It is broken for mingw and i686. We dont have the proper infrastructure for this at the moment to properly exclude it for broken platforms. Also it doesn't even make much sense to build it in hydra tbh because that code is never exercised anyway and is there purely for the docs. |
edolstra
approved these changes
Dec 8, 2025
Member
|
Yeah one platform is definitely enough. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Should fix all the failing jobs on master hydra jobset. See individual commits.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.