Check and fix nix-manual redirect targets#14711
Merged
Ericson2314 merged 4 commits intoNixOS:masterfrom Dec 5, 2025
Merged
Conversation
2 tasks
roberth
force-pushed
the
check-redirect-targets
branch
2 times, most recently
from
a9a7651 to
23503ef
Compare
Member
|
Shouldn't this be removing the old redirects file? |
Augments the manual with a generated file before running the usual check.
Since it is apparently not deployed correctly on nix.dev, we can't meaningfully work with it now.
Most of them were fixable. The S3 ones were made available in c5ed22d.
roberth
force-pushed
the
check-redirect-targets
branch
from
23503ef to
c8601a2
Compare
Member
Author
Whoops. Had my thoughts terminated by the clang-format json formatter apparently. I've removed the file and tested a |
2 tasks
Ericson2314
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The redirects weren't checked, so a lot of them were broken, see last commit.
Changes
redirects.json, reassembed at build time. Manually tested ✔️Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.