Use std::filesystem::path in libflake.#14659
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Nov 27, 2025
Merged
Conversation
Ericson2314
approved these changes
Nov 26, 2025
Contributor
|
@Ericson2314 can we please at least first make sure that mingw build still works before merging so much stuff? |
Contributor
|
Here's the issue #14662. Would be nice to address first and to make sure that it builds this time. |
Member
|
My plan was just to go fix it afterwards. I figured the incremental conversation meant we might get a bunch of How does that sound? |
xokdvium
approved these changes
Nov 26, 2025
xokdvium
reviewed
Nov 26, 2025
xokdvium
reviewed
Nov 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Ugh flake regression failure in merge queue looked spurious. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Use std::filesystem::path in libflake.
Context
#9205
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.