DrvOutputSubstitutionGoal: Don't actually fetch any store objects #14648
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Dec 17, 2025
Merged
DrvOutputSubstitutionGoal: Don't actually fetch any store objects #14648Ericson2314 merged 2 commits intoNixOS:masterfrom
DrvOutputSubstitutionGoal: Don't actually fetch any store objects #14648Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
documentation
with-tests
Ericson2314
force-pushed
the
goal-division-of-labor
branch
from
00460c3 to
a1127e9
Compare
Ericson2314
force-pushed
the
goal-division-of-labor
branch
3 times, most recently
from
d318599 to
9610eaf
Compare
This progress on NixOS#11896. It introduces some issues temporarily which will be fixed when NixOS#11928 is fixed. The SQL tables are left in place because there is no point inducing a migration now, when we will be immediately landing more changes after this that also require schema changes. They will simply be ignored by in this commit, and so all data will be preserved.
Ericson2314
force-pushed
the
goal-division-of-labor
branch
from
9610eaf to
8e6625d
Compare
We now have a nice separation of concerns: `DrvOutputSubstitutionGoal` is *just* for getting realisations, and `PathSubstitutionGoal` is just for fetching store objects. The fetching of store objects that this used to do is now moved to the caller.
Ericson2314
force-pushed
the
goal-division-of-labor
branch
from
8e6625d to
018d646
Compare
xokdvium
approved these changes
Dec 17, 2025
Contributor
xokdvium
left a comment
xokdvium
left a comment
There was a problem hiding this comment.
The second commit lgtm. The renaming churn is yet tbd
|
🎉 All dependencies have been resolved ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We now have a nice separation of concerns:
DrvOutputSubstitutionGoalis just for getting realisations, andPathSubstitutionGoalis just for fetching store objects.The fetching of store objects that this used to do is now moved to the caller.
Context
depends on #14247
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.