Simplify nix develop "gathering derivation environment"#14641
Merged
Ericson2314 merged 4 commits intoNixOS:masterfrom Nov 25, 2025
Merged
Simplify nix develop "gathering derivation environment"#14641Ericson2314 merged 4 commits intoNixOS:masterfrom
nix develop "gathering derivation environment"#14641Ericson2314 merged 4 commits intoNixOS:masterfrom
Conversation
Ericson2314
force-pushed
the
simplify-nix-develop
branch
from
8bb7eb1 to
e2be94c
Compare
edolstra
approved these changes
Nov 25, 2025
Without this change, when one runs wit with `meson test --interactive`, that command will block waiting on standard input to be closed.
It half works today, we should fix this but also not regress it!
Ericson2314
force-pushed
the
simplify-nix-develop
branch
from
e2be94c to
0314c89
Compare
github-actions
bot
added
the
with-tests
Member
Author
|
I found another bug with fixed-output derivations and also fixed it. |
Before, had some funny logic with an unnecessary is CA enabled branch, and erroneous use of the comma operator. Now, take advantage of the new `Derivation::fillInOutputPaths` to fill in input addresses (and output path env vars) in a much-more lightweight manner. Also, fix `nix develop` on fixed-output derivations so that weird things don't happen when we have that experimental feature enabled. As a slight behavior change, if the original derivation was content-addressing this one will be too, but I really don't think that matters --- if anything, it is a slight improvement for users that have already opted into content-addressing anyways.
Ericson2314
force-pushed
the
simplify-nix-develop
branch
from
0314c89 to
801cb16
Compare
It's very weird it doesn't work here, but I don't mind not debugging this now as I just added this part of the functional test --- it's already better than it was before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before, had some funny logic with an unnecessary is CA enabled branch, and erroneous use of the comma operator. Now, take advantage of the new
Derivation::fillInOutputPathsto fill in input addresses (and env vars) in a much-more lightweight manner.Also, fix
nix developon fixed-output derivations so that weird things don't happen when we have that experimental feature enabled.Context
As a slight behavior change, if the original derivation was content-addressing this one will be too, but I really don't think that matters --- if anything, it is a slight improvement for users that have already opted into content-addressing anyways.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.