libexpr: move the ExprLet::attrs allocations into the arena#14635
Merged
Ericson2314 merged 2 commits intoNixOS:masterfrom Nov 24, 2025
Merged
libexpr: move the ExprLet::attrs allocations into the arena#14635Ericson2314 merged 2 commits intoNixOS:masterfrom
Ericson2314 merged 2 commits intoNixOS:masterfrom
Conversation
I missed this because I assumed all Exprs were recursed into by bindVars, but ExprLet's ExprAttrs field is not really its own AST node, so it doesn't get recursed into.
Radvendii
force-pushed
the
alloc-exprlet-exprattrs
branch
from
891038c to
60f0992
Compare
Ericson2314
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #14539, I missed that
ExprLethas anExprAttrsparameter that doesn't get recursed into duringbindVars.This PR plugs that leak, and also factors out the moving-to-different-allocator code into a separate function.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.