libstore: fix curl version check to allow 8.17.0#14627
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Nov 23, 2025
Merged
Conversation
xokdvium
approved these changes
Nov 23, 2025
The single-string syntax '>=8.16.0 <8.17.0' only applied the lower bound, causing curl 8.17.0 to be incorrectly rejected. Split into two separate version_compare() calls for compatibility with Meson 1.1, since multi-argument syntax requires Meson 1.8+.
xokdvium
force-pushed
the
libstore-curl-version-maximum
branch
from
a604890 to
76ed967
Compare
Contributor
|
Fixed formatting. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The single-string syntax '>=8.16.0 <8.17.0' only applied the lower bound, causing curl 8.17.0 to be incorrectly rejected. Split into two separate version_compare() calls for compatibility with Meson 1.1, since multi-argument syntax requires Meson 1.8+.
Motivation
Meson wouldn't let me configure Nix with curl 8.17.0, even though the write pausing bug should be fixed in this version:
Context
The version check introduced in #14614 incorrectly rejects curl 8.17.0. The single-string version comparison syntax
'>=8.16.0 <8.17.0'only applied the lower bound in Meson, causing builds with curl 8.17.0 to fail even though the bug (curl/curl#19334) was fixed in that version.Split into two separate
version_compare()calls to work correctly and maintain compatibility with Meson 1.1 (multi-argument syntax requires Meson 1.8+).Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.