Skip to content

Turn one unsafe C cast into a safe static_cast#14603

Merged
Ericson2314 merged 1 commit intomasterfrom
safe-cast
Nov 20, 2025
Merged

Turn one unsafe C cast into a safe static_cast#14603
Ericson2314 merged 1 commit intomasterfrom
safe-cast

Conversation

@Ericson2314
Copy link
Member

Motivation

Safety is better.

Context

This bit me during a refactor.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@github-actions github-actions bot added the new-cli Relating to the "nix" command label Nov 20, 2025
Copy link
Contributor

@xokdvium xokdvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the day that c-style casts are forbidden with a clang-tidy rule...

@Ericson2314 Ericson2314 added this pull request to the merge queue Nov 20, 2025
Merged via the queue into master with commit ec3c93f Nov 20, 2025
20 checks passed
@Ericson2314 Ericson2314 deleted the safe-cast branch November 20, 2025 22:15
@edolstra edolstra mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-cli Relating to the "nix" command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants