libutil: Remove really dead code for git hashing#14602
Draft
libutil: Remove really dead code for git hashing#14602
Conversation
It's not being excersised by anything and already contains bugs (like the fact that copyRecursive only handles the first entry in a directory). Evidently, it can just be removed and was never used by anything.
Contributor
Author
|
There seems to have been some back-and-forth with this code #10084. Pretty sure it's actually dead this time? @Ericson2314 |
Member
|
I need to keep spelunking, but are some of my unmerged PRs for more git tree hashing stuff |
xokdvium
commented
Nov 20, 2025
Comment on lines
-38
to
-40
| for (auto & [name, _] : accessor.readDirectory(from)) { | ||
| copyRecursive(accessor, from / name, dirSink, relDirPath / name); | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
This is the buggy line in question. break shouldn't be there
Ericson2314
approved these changes
Nov 20, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
If I end up needing this, we can revert.
Contributor
Author
|
Seems like there's a good use-case for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It's not being excersised by anything and already contains bugs (like the fact that copyRecursive only handles the first entry in a directory). Evidently, it can just be removed and was never used by anything.
Context
#14597 (comment)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.