Open
Conversation
Member
|
You could polyfill
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As first described here #8430
@adisbladis and me run a test where we reimplemented
lib.findFirstIndexin terms of the new builtin.Motivation
The idea was that
findFirstIndexis exhaustive, running more iterations than necessary.Using a
trampolineit would be turned intoO(n)worst case, fromO(n)generally.Observation
Running
nix-instantiate pkgs.jqsaved ~100thunksTakeway this might NOT be worth it - for the sake of exhaustive iterations in nixpkgs.
Maybe somebody has better use-case for it? I.e. the mentioned tail-recursing, or on bigger lists?
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.