Sort the builtins.fetchTree doc's lists#14545
Merged
Ericson2314 merged 1 commit intomasterfrom Nov 12, 2025
Merged
Conversation
This makes the output easier to compare with the new machine-generated lists in #9732. The hand-curated order did have the advantage of putting more important attributes at the top, but I don't think it is worth preserving that when `std::map` is so much easier to work with. The right solution to leading the reader to the more important attributes is to call them out in the intro texts.
edolstra
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This makes the output easier to compare with the new machine-generated lists in #9732.
Context
The hand-curated order did have the advantage of putting more important attributes at the top, but I don't think it is worth preserving that when
std::mapis so much easier to work with. The right solution to leading the reader to the more important attributes is to call them out in the intro texts.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.