Skip to content

move allocBytes() into EvalMemory#14544

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
Radvendii:evalmemory-alocbytes
Nov 11, 2025
Merged

move allocBytes() into EvalMemory#14544
Ericson2314 merged 1 commit intoNixOS:masterfrom
Radvendii:evalmemory-alocbytes

Conversation

@Radvendii
Copy link
Contributor

Motivation

  • allocBytes() deals with memory so it should be in EvalMemory
  • Practically, this allows us more flexibility in where we allocate memory.
    • For instance for testing, we can disable the garbage collector but put all allocations in an arena and that way detect other memory leaks

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@Radvendii Radvendii requested a review from edolstra as a code owner November 11, 2025 16:50
@Ericson2314 Ericson2314 added this pull request to the merge queue Nov 11, 2025
Merged via the queue into NixOS:master with commit af0ac14 Nov 11, 2025
16 checks passed
@edolstra edolstra mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants