Use less c_str() in the evaluator, and other cleanups
#14444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-cli
Ericson2314
requested review from
Radvendii,
edolstra and
xokdvium
and removed request for
edolstra
Member
Author
|
Cool PR number :) |
Ericson2314
commented
Nov 1, 2025
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
less-c_str
branch
from
ef88936 to
62c6368
Compare
xokdvium
reviewed
Nov 2, 2025
It is better to avoid null termination for performance and memory safety, wherever possible. These are good cleanups extracted from the Pascal String work that we can land by themselves first, shrinking the diff in that PR. Co-Authored-By: Aspen Smith <[email protected]> Co-Authored-By: Sergei Zimmerman <[email protected]>
Member
Author
|
@xokdvium otherwise looks good? |
Contributor
|
Yeah. I got rid of the bit_casts so this should be good to go |
Contributor
|
This does mean that we are doing a bit more implicit |
Member
Author
|
Yes yeah it is very slight performance degradation (until we do the next PR). Not surprised it was non-measurable. |
xokdvium
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is better to avoid null termination for performance and memory
safety, wherever possible.
Context
These are good cleanups extracted from the Pascal String work (#14442) that we can land by themselves first, shrinking the diff in that PR.
Co-Authored-By: @glittershark
depends on #14443
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.