Skip to content

Conversation

@Ericson2314
Copy link
Member

Motivation

More JSON!

CC @mschwaig @edef1c it occurs to me that perhaps BuildResult was (at least closer to) the type for build trace values we wanted all along. E.g. being able to sign build failures is cool, and if we move the signature here, we also sign for all the outputs at once as @mschwaig wanted.

Context

Depends on #14425


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra
Copy link
Member

FWIW Determinate Nix also has a JSON serialization for BuildResult: https://github.com/DeterminateSystems/nix-src/blob/236ebef6514f3a2a9765c8a1d80dd503b8e672be/src/libstore/build-result.cc. This is used to provide structured JSON log messages containing the build result. Might be worth having a look at that to avoid a compatibility issue.

One difference is that the status strings follow the enum values, i.e. ResolvesToAlreadyValid instead of resolves to already valid. I feel the use of whitespace falsely suggests that these are arbitrary human-readable strings rather than enum values.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Oct 31, 2025

That looks like the only difference? I'm happy to go back to camel case. I had a similar feeling after I did it that way too.

edit this is now done.

@Ericson2314 Ericson2314 force-pushed the json-schema-build-result branch 3 times, most recently from e7028e8 to a162262 Compare November 3, 2025 20:41
Note, starting to make progress on NixOS#11895 by calling it this in the
manual.
@Ericson2314 Ericson2314 force-pushed the json-schema-build-result branch from a162262 to f87079c Compare November 3, 2025 21:01
@Ericson2314
Copy link
Member Author

OK This is now converted to camel case, matching the det sys serialization.

@Ericson2314 Ericson2314 force-pushed the json-schema-build-result branch from f87079c to 389bcba Compare November 3, 2025 23:26
@Mic92 Mic92 added this pull request to the merge queue Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Nov 6, 2025
@Mic92 Mic92 added this pull request to the merge queue Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Nov 6, 2025
@dpulls
Copy link

dpulls bot commented Nov 6, 2025

🎉 All dependencies have been resolved !

@Ericson2314 Ericson2314 added this pull request to the merge queue Nov 6, 2025
Merged via the queue into NixOS:master with commit 147e183 Nov 6, 2025
17 checks passed
@Ericson2314 Ericson2314 deleted the json-schema-build-result branch November 6, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants