refactor(libstore): add HttpBinaryCacheStore::upload method#14421
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 30, 2025
Merged
refactor(libstore): add HttpBinaryCacheStore::upload method#14421Ericson2314 merged 1 commit intoNixOS:masterfrom
HttpBinaryCacheStore::upload method#14421Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
http-upload
branch
2 times, most recently
from
ad46b1a to
1cfef61
Compare
Introduce protected `upload` method overloads in `HttpBinaryCacheStore` that handle the actual upload after compression has been applied. This separates compression concerns (in `upsertFile`) from upload mechanics (in `upload`). Two overloads are provided: 1. `upload(path, RestartableSource &, sizeHint, mimeType, contentEncoding)` 2. `upload(path, CompressedSource &, mimeType)`
lovesegfault
force-pushed
the
http-upload
branch
from
1cfef61 to
d857a4b
Compare
Ericson2314
approved these changes
Oct 30, 2025
|
🎉 All dependencies have been resolved ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce protected
uploadmethod overloads inHttpBinaryCacheStorethat handle the actual upload after compression has been applied. This
separates compression concerns (in
upsertFile) from upload mechanics(in
upload).Two overloads are provided:
upload(path, RestartableSource &, sizeHint, mimeType, contentEncoding)upload(path, CompressedSource &, mimeType)Context
Part-Of: #14330
Depends-On: #14420
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.