Convert store path info JSON docs to formal JSON Schema, and test#14399
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 30, 2025
Merged
Convert store path info JSON docs to formal JSON Schema, and test#14399Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
This continues the work for formalizing our current JSON docs. Note that in the process, a few bugs were caught: - `closureSize` was repeated twice, forgot `closureDownloadSize` - `file*` fields should be `download*`. They are in fact called that in the line-oriented `.narinfo` file, but were renamed in the JSON format.
ef23bec to
6280905
Compare
roberth
approved these changes
Oct 29, 2025
Member
roberth
left a comment
There was a problem hiding this comment.
✔️ tests
✔️ docs
Looking forward to v2 ;)
Mic92
approved these changes
Oct 30, 2025
32 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This continues the work for formalizing our current JSON docs. Note that in the process, a few bugs were caught:
closureSizewas repeated twice, forgotclosureDownloadSizefile*fields should bedownload*. They are in fact called that in the line-oriented.narinfofile, but were renamed in the JSON format.Context
One of my many JSON schema PRs as of late.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.