Skip to content

Convert store path info JSON docs to formal JSON Schema, and test#14399

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:json-schema-path-info
Oct 30, 2025
Merged

Convert store path info JSON docs to formal JSON Schema, and test#14399
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:json-schema-path-info

Conversation

@Ericson2314
Copy link
Member

Motivation

This continues the work for formalizing our current JSON docs. Note that in the process, a few bugs were caught:

  • closureSize was repeated twice, forgot closureDownloadSize

  • file* fields should be download*. They are in fact called that in the line-oriented .narinfo file, but were renamed in the JSON format.

Context

One of my many JSON schema PRs as of late.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@Ericson2314 Ericson2314 requested a review from edolstra as a code owner October 28, 2025 20:02
@NixOS NixOS deleted a comment from coderabbitai bot Oct 28, 2025
This continues the work for formalizing our current JSON docs. Note that
in the process, a few bugs were caught:

 - `closureSize` was repeated twice, forgot `closureDownloadSize`

 - `file*` fields should be `download*`. They are in fact called that in
   the line-oriented `.narinfo` file, but were renamed in the JSON
   format.
@Ericson2314 Ericson2314 force-pushed the json-schema-path-info branch from ef23bec to 6280905 Compare October 29, 2025 03:29
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ tests
✔️ docs

Looking forward to v2 ;)

@Ericson2314 Ericson2314 enabled auto-merge October 29, 2025 21:38
@Ericson2314 Ericson2314 added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NixOS:master with commit 7e2d2db Oct 30, 2025
17 checks passed
@Ericson2314 Ericson2314 deleted the json-schema-path-info branch October 30, 2025 18:19
@edolstra edolstra mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants