feat(libstore/s3-binary-cache-store): implement uploadPart()#14375
Merged
Mic92 merged 11 commits intoNixOS:masterfrom Oct 27, 2025
Merged
feat(libstore/s3-binary-cache-store): implement uploadPart()#14375Mic92 merged 11 commits intoNixOS:masterfrom
uploadPart()#14375Mic92 merged 11 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
77a6fd8 to
5a57950
Compare
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
5a57950 to
4668859
Compare
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
|
🎉 All dependencies have been resolved ! |
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
4668859 to
fe273cd
Compare
Implement `abortMultipartUpload()` for cleaning up incomplete multipart uploads on error: - Constructs URL with `?uploadId=ID` query parameter - Issues `DELETE` request to abort the multipart upload
…king Introduces `scanForReferencesDeep` to provide per-file granularity when scanning for store path references, enabling better diagnostics for cycle detection and `nix why-depends --precise`.
Replaces manual tree-walking and reference scanning with the new scanForReferencesDeep function.
…nt-address ` nlohmann::json` instance and JSON Schema for `ContentAddress`
feat(libstore/s3-binary-cache-store): implement `abortMultipartUpload()`
…detailed feat(libstore): add scanForReferencesDeep and use it for why-depends
Ericson2314
reviewed
Oct 27, 2025
Ericson2314
reviewed
Oct 27, 2025
Ericson2314
reviewed
Oct 27, 2025
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
fe273cd to
1699019
Compare
Ericson2314
approved these changes
Oct 27, 2025
Ericson2314
reviewed
Oct 27, 2025
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
1699019 to
e7667ee
Compare
libexpr: store ExprList data in Exprs::alloc
…d()` POST to key with `?uploads` query parameter, optionally set `Content-Encoding` header, parse `uploadId` from XML response using regex
Implement `uploadPart()` for uploading individual parts in S3 multipart uploads: - Constructs URL with `?partNumber=N&uploadId=ID` query parameters - Uploads chunk data with `application/octet-stream` mime type - Extracts and returns `ETag` from response
auto-merge was automatically disabled
October 27, 2025 21:09
Head branch was pushed to by a user without write access
lovesegfault
force-pushed
the
nix-s3-upload-part
branch
from
e7667ee to
c592090
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implement
uploadPart()for uploading individual parts in S3 multipartuploads:
?partNumber=N&uploadId=IDquery parametersapplication/octet-streammime typeETagfrom responseContext
Part-Of: #14330
Depends-On: #14377
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.