feat(libstore/s3-binary-cache-store): implement createMultipartUpload()#14374
Merged
10 commits merged intoNixOS:masterfrom Oct 27, 2025
Merged
feat(libstore/s3-binary-cache-store): implement createMultipartUpload()#1437410 commits merged intoNixOS:masterfrom
createMultipartUpload()#1437410 commits merged intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
nix-s3-create-multipart
branch
from
4cbc41c to
1b5680e
Compare
Ericson2314
reviewed
Oct 27, 2025
Ericson2314
reviewed
Oct 27, 2025
lovesegfault
force-pushed
the
nix-s3-create-multipart
branch
2 times, most recently
from
7ad05c5 to
777e420
Compare
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
|
🎉 All dependencies have been resolved ! |
lovesegfault
force-pushed
the
nix-s3-create-multipart
branch
from
777e420 to
71f8011
Compare
Implement `abortMultipartUpload()` for cleaning up incomplete multipart uploads on error: - Constructs URL with `?uploadId=ID` query parameter - Issues `DELETE` request to abort the multipart upload
Ericson2314
approved these changes
Oct 27, 2025
…king Introduces `scanForReferencesDeep` to provide per-file granularity when scanning for store path references, enabling better diagnostics for cycle detection and `nix why-depends --precise`.
Replaces manual tree-walking and reference scanning with the new scanForReferencesDeep function.
…nt-address ` nlohmann::json` instance and JSON Schema for `ContentAddress`
feat(libstore/s3-binary-cache-store): implement `abortMultipartUpload()`
…detailed feat(libstore): add scanForReferencesDeep and use it for why-depends
libexpr: store ExprList data in Exprs::alloc
…d()` POST to key with `?uploads` query parameter, optionally set `Content-Encoding` header, parse `uploadId` from XML response using regex
lovesegfault
force-pushed
the
nix-s3-create-multipart
branch
from
71f8011 to
4b6d07d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to it being already merged
github-merge-queue
bot
closed this pull request by merging all changes
into
NixOS:master
in
dd0d006
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
POST to key with
?uploadsquery parameter, optionally setContent-Encodingheader, parseuploadIdfrom XML response usingregex
Context
Part-Of: #14330
Depends-On: #14377
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.