fix(libstore): Rewrite hard linking message to be more clear#14363
Merged
tomberek merged 1 commit intoNixOS:masterfrom Oct 30, 2025
Merged
fix(libstore): Rewrite hard linking message to be more clear#14363tomberek merged 1 commit intoNixOS:masterfrom
tomberek merged 1 commit intoNixOS:masterfrom
Conversation
tomberek
approved these changes
Oct 29, 2025
cootshk
changed the title
Contributor
|
Rebase/squash the commit into one please. |
Contributor
Author
|
@tomberek done! |
tomberek
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I saw the hard linking message on my own
sudo nix-collect-garbage -dand assumed that I could shave off 30G+ from the nix store.Context
"Currently hard linking saves" is grammatically incorrect and should be "Currently**,** hard linking saves". "Currently, hard linking saves" implies that hard linking is not being done at the moment.
"Hard linking is currently saving" explicitly states that the hard linking has already been applied.
I couldn't find an open issue about this, however the consensus in the Nix Cult discord is that this is bad wording.
This is a non-trivial message change and isn't likely to impact any use cases.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.