feat(libstore/s3-binary-cache-store): implement create/completeMultipartUpload()#14355
Closed
lovesegfault wants to merge 4 commits intoNixOS:masterfrom
Closed
feat(libstore/s3-binary-cache-store): implement create/completeMultipartUpload()#14355lovesegfault wants to merge 4 commits intoNixOS:masterfrom
create/completeMultipartUpload()#14355lovesegfault wants to merge 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
xokdvium
reviewed
Oct 25, 2025
| const std::string & key, const std::string & mimeType, const std::optional<std::string> & contentEncoding); | ||
| void completeMultipartUpload( | ||
| const std::string & key, | ||
| const std::string & uploadId, |
Contributor
There was a problem hiding this comment.
Shouldn't this be an integer?
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
it's the partNumber that's a uint64_t
lovesegfault
force-pushed
the
s3-init-complete
branch
from
cadda60 to
15c65be
Compare
lovesegfault
force-pushed
the
s3-init-complete
branch
2 times, most recently
from
f0fe86f to
10012a5
Compare
lovesegfault
changed the title
initiate/completeMultipartUpload()create/completeMultipartUpload()
lovesegfault
force-pushed
the
s3-init-complete
branch
from
10012a5 to
098fe18
Compare
…d()` POST to key with `?uploads` query parameter, optionally set `Content-Encoding` header, parse `uploadId` from XML response using regex
…oad()` `completeMultipartUpload()`: Build XML with part numbers and `ETags`, POST to key with `?uploadId` to finalize the multipart upload
lovesegfault
force-pushed
the
s3-init-complete
branch
from
098fe18 to
c9cfa41
Compare
Member
Author
|
I'm going to do this in another order to ease review, actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
createMultipartUpload()completeMultipartUpload()Context
Part-Of: #14330
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.