Revert "libmain: Catch logger exceptions in handleExceptions"#14343
Merged
Revert "libmain: Catch logger exceptions in handleExceptions"#14343
handleExceptions"#14343Conversation
cole-h
approved these changes
Oct 23, 2025
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
A user recently encountered this as well, and this does indeed fix it in this case (previously, literally 0 output, now, proper error about the hash being busted, as we eventually found out through manual investigation).
xokdvium
added
backport 2.31-maintenance
Ericson2314
approved these changes
Oct 24, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
I'm down to at least try this. I sort of get a smell either way but didn't think about it too hard.
|
Successfully created backport PR for |
|
Successfully created backport PR for |
2 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This reverts commit 90d1ff4.
The initial issue with EPIPE was solved in 9f68087. Now this patch does more bad than good by eating up boost::io::format_error that are bugs.
Context
#14236
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.