fix(libstore): use CURLOPT_POSTFIELDSIZE_LARGE for POST requests#14337
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Oct 23, 2025
Merged
fix(libstore): use CURLOPT_POSTFIELDSIZE_LARGE for POST requests#14337xokdvium merged 1 commit intoNixOS:masterfrom
xokdvium merged 1 commit intoNixOS:masterfrom
Conversation
Fix POST requests with data to use the correct curl option for specifying body size. Previously used CURLOPT_INFILESIZE_LARGE for both POST and PUT, but POST requires CURLOPT_POSTFIELDSIZE_LARGE. This caused POST request bodies to not be sent correctly, manifesting as S3 multipart CompleteMultipartUpload requests failing with "You must specify at least one part" even though the XML body contained valid parts.
xokdvium
reviewed
Oct 23, 2025
xokdvium
approved these changes
Oct 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix POST requests with data to use the correct curl option for specifying
body size. Previously used CURLOPT_INFILESIZE_LARGE for both POST and PUT,
but POST requires CURLOPT_POSTFIELDSIZE_LARGE.
This caused POST request bodies to not be sent correctly, manifesting as
S3 multipart CompleteMultipartUpload requests failing with "You must
specify at least one part" even though the XML body contained valid parts.
Context
Part-Of: #14330
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.