refactor(libstore): extract getCompressionMethod() in HttpBinaryCacheStore#14335
Merged
xokdvium merged 1 commit intoNixOS:masterfrom Oct 23, 2025
Merged
Conversation
github-actions
bot
added
the
store
Ericson2314
reviewed
Oct 23, 2025
…Store Extract the path-based compression method determination logic into a protected method that returns std::optional<std::string>. This allows subclasses to reuse the logic and makes the semantics clearer (nullopt means no compression, not empty string). This prepares for S3BinaryCacheStore to apply the same compression rules when implementing multipart uploads.
lovesegfault
force-pushed
the
extract-getcompressionmethod
branch
from
2bcc439 to
b047cec
Compare
xokdvium
approved these changes
Oct 23, 2025
|
|
||
| protected: | ||
|
|
||
| std::optional<std::string> getCompressionMethod(const std::string & path) |
Contributor
There was a problem hiding this comment.
In the future this could just become an enum for content encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Extract the path-based compression method determination logic into a
protected method that returns
std::optional<std::string>. This allowssubclasses to reuse the logic and makes the semantics clearer (nullopt
means no compression, not empty string).
This prepares for S3BinaryCacheStore to apply the same compression
rules when implementing multipart uploads.
Context
Part-Of: #14330
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.