refactor(libstore): add sizeHint parameter to upsertFile()#14333
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Oct 24, 2025
Merged
refactor(libstore): add sizeHint parameter to upsertFile()#14333Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
upsert-size-hint
branch
from
4b0992d to
3197e00
Compare
lovesegfault
changed the title
edolstra
approved these changes
Oct 23, 2025
Member
edolstra
left a comment
edolstra
left a comment
There was a problem hiding this comment.
LGTM other than the function argument issue.
xokdvium
force-pushed
the
upsert-size-hint
branch
from
3197e00 to
3428e02
Compare
xokdvium
reviewed
Oct 23, 2025
Add a sizeHint parameter to BinaryCacheStore::upsertFile() to enable size-based upload decisions in implementations. This lays the groundwork for reintroducing S3 multipart upload support.
lovesegfault
force-pushed
the
upsert-size-hint
branch
from
3428e02 to
6b7223b
Compare
Ericson2314
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a sizeHint parameter to BinaryCacheStore::upsertFile() to enable
size-based upload decisions in implementations. This lays the groundwork
for reintroducing S3 multipart upload support.
Context
Part-Of: #14330
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.