Conversation
This is slightly faster than doing a read() into a buffer just to discard the data.
github-actions
bot
added
the
store
xokdvium
reviewed
Oct 22, 2025
edolstra
force-pushed
the
skip-nar-parse
branch
from
2fcd812 to
9ecdb01
Compare
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Ericson2314
reviewed
Oct 22, 2025
xokdvium
reviewed
Oct 22, 2025
`skip()` can throw an exception, which we need to ignore since we may be unwinding an exception.
xokdvium
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This speeds up the case when we're adding a path that already exists in the store, and we're reading from a seekable source (e.g. in
nix-store --import).Note that this does require the
narSizefield to be correct, but that seems like a reasonable assumption.Taken from DeterminateSystems#238.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.