Open
Conversation
Ericson2314
force-pushed
the
cleanup-after-14193
branch
from
3a53e87 to
35b08b7
Compare
Ericson2314
force-pushed
the
cleanup-after-14193
branch
from
35b08b7 to
33f18c6
Compare
This is the exact same control flow, but with one less branch because it becomes redundant.
Ericson2314
force-pushed
the
cleanup-after-14193
branch
from
33f18c6 to
627d886
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This does some more simplifications/improvements after #14280 fixed the bug.
The first commit is no behavior change, and just simplifies the control flow.
The second commit I believes improves behavior by ensuring that we also call
optimisePathin the repair case, while still not unnecessarily doing it in the already-built case.Context
#14280
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.